mpezzi / bootstrap

A Twitter Bootstrap base theme for Drupal.
26 stars 8 forks source link

Theme breaks Date fields in node form #7

Open fixed opened 11 years ago

fixed commented 11 years ago

Date fields with jQueryUI calendar popups are just hidden. No way to edit them. Works with Garland, though.

mpezzi commented 11 years ago

Maybe an issue with jQuery versions? I know Bootstrap requires jQuery 1.7+ and Drupal ships with jQuery UI 1.8.11. I have encountered some bugs when using jQuery Update 7.x-2.x-dev on the admin side.

I'm not really using Bootstrap as a backend admin theme, but any help in this area is greatly appreciated!

fixed commented 11 years ago

Well, I don't get any errors anymore, as I fixed the the most template functions in your theme. However, even though I am running with jQ 1.7.1, it seems to have some quirks (no JS errors either, though) .. I will investigate it further ..

fixed commented 11 years ago

It seems that some modules (especially the ones using JS) expect the form element DOM structure to be as defined by the Drupal theming system whereas the Bootstrap themes wraps elements in further div's (.control-group & .controls). Is this really needed or can't we just alter the ones already created ?

mpezzi commented 11 years ago

Interesting ... is the script looking to attach itself using an id or class? To get bootstrap's forms themed we need to wrap them with these extra elements. Maybe we can merge ids and classes? I'll have to look into it.

Can you provide the module versions you're using?

fixed commented 11 years ago

I've looked into the bootstrap docs and there are only a few places where these extra elements are needed (horizontal forms and error reporting I believe).. Either way, my Date fields seem to work now. Must have been something with the cache ..