mpgirro / stalla

A Kotlin and Java library for RSS podcast feeds
https://stalla.dev
BSD 3-Clause "New" or "Revised" License
26 stars 5 forks source link

Reader based public API, fix tests #71

Closed rock3r closed 3 years ago

rock3r commented 3 years ago

This PR implements a Reader/Writer public API for the RSS parser and writer. In addition, the internal delegation chain in PodcastRssParser#parse and PodcastRssWriter#write have been streamlined — now they all delegate to a "main" implementation, making the other overloads just conveniences on top of that. This simplifies the code and exceptions handling, and ensures consistent behaviour.

On top of that, this PR makes some minor changes to make the tests pass under Windows — for whatever reason it dislikes reading resources the way we were doing before.

Lastly, I now ensure we run Detekt's type-aware detektMain task on any run of :check. The CI is now set up to run checks on Windows, as well as on Linux, to avoid further issues in the future. I am not adding macOS because we don't really need it for now.

Once this is merged, it'll unblock the #56 PR.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build #59


Totals Coverage Status
Change from base Build #50: 0.2%
Covered Lines: 2340
Relevant Lines: 2418

💛 - Coveralls
rock3r commented 3 years ago

Sorted @mpgirro :)

mpgirro commented 3 years ago

LGTM 👍