search

mpgirro / stalla

A Kotlin and Java library for RSS podcast feeds
https://stalla.dev
BSD 3-Clause "New" or "Revised" License
26 stars 5 forks source link

Add support for content:encoded support for Podcast #94

Open rock3r opened 3 years ago

rock3r commented 3 years ago

We are modeling the content:encoded for the <item> nodes, but not for the <channel> nodes. That's not great, because many podcasts use it (e.g., src/test/resources/xml/real-life-feeds/reply-all.xml). We should add a PodcastContent.

rock3r commented 3 years ago

I have done this but it is a breaking change both in terms of source and binary compatibility. I can create a 2.0.0 branch once #95 is merged, and we can consider shipping 1.1.0 since it has a meaty set of changes as it is already. What do you think @mpgirro?

mpgirro commented 3 years ago

I'm fine with shipping 1.1.0. I've got about half of #76 done, but won't be able to finish it in the near future. Just something for 1.2.0 then :)

rock3r commented 3 years ago

Makes sense. I'll tag and release 1.1.0, and create 1.2.0 and 2.0.0 milestones.

mpgirro commented 3 years ago

👍

rock3r commented 3 years ago

I've discovered a pretty severe bug with the List<...>.asBuilders() implementations, I'm working on a fix and will release 1.1 after that's shipped.