Closed rock3r closed 3 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build #118: | -9.7% |
Covered Lines: | 2484 |
Relevant Lines: | 2852 |
Just a quick note: most of the new lines are equals/hashcode/toString in the validating builders. Unfortunately, this brings down coverage, but I'm not going to test autogenerated code...
Oh boy, this is a pretty severe issue. Good that you've notices this!
The coverage impact is a downer of course, but you're right of course, there is no point in testing generated code.
LGTM 👍
v1.1.0 is ready to be shipped from my perspective.
They used to return a list made up of the same builder repeated
n
times, wheren
is the size of the source list, instead of n builders.This requires a number of internal (non API breaking) changes to all validating builders.