mpgirro / stalla

A Kotlin and Java library for RSS podcast feeds
https://stalla.dev
BSD 3-Clause "New" or "Revised" License
26 stars 5 forks source link

Fix all the `asBuilders()` functions #98

Closed rock3r closed 3 years ago

rock3r commented 3 years ago

They used to return a list made up of the same builder repeated n times, where n is the size of the source list, instead of n builders.

This requires a number of internal (non API breaking) changes to all validating builders.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build #120

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/kotlin/dev/stalla/builder/validating/episode/ValidatingEpisodeBitloveBuilder.kt 7 9 77.78%
src/main/kotlin/dev/stalla/builder/validating/episode/ValidatingEpisodeContentBuilder.kt 7 9 77.78%
src/main/kotlin/dev/stalla/builder/validating/episode/ValidatingEpisodePodloveBuilder.kt 4 6 66.67%
src/main/kotlin/dev/stalla/builder/validating/ValidatingHrefOnlyImageBuilder.kt 5 9 55.56%
src/main/kotlin/dev/stalla/builder/validating/ValidatingRssCategoryBuilder.kt 8 12 66.67%
src/main/kotlin/dev/stalla/builder/validating/episode/ValidatingEpisodeGuidBuilder.kt 7 11 63.64%
src/main/kotlin/dev/stalla/builder/validating/podcast/ValidatingPodcastFyydBuilder.kt 5 9 55.56%
src/main/kotlin/dev/stalla/builder/validating/podcast/ValidatingPodcastPodcastindexFundingBuilder.kt 10 14 71.43%
src/main/kotlin/dev/stalla/builder/validating/ValidatingAtomBuilder.kt 6 11 54.55%
src/main/kotlin/dev/stalla/builder/validating/episode/ValidatingEpisodeEnclosureBuilder.kt 13 18 72.22%
<!-- Total: 242 536 45.15% -->
Totals Coverage Status
Change from base Build #118: -9.7%
Covered Lines: 2484
Relevant Lines: 2852

💛 - Coveralls
rock3r commented 3 years ago

Just a quick note: most of the new lines are equals/hashcode/toString in the validating builders. Unfortunately, this brings down coverage, but I'm not going to test autogenerated code...

mpgirro commented 3 years ago

Oh boy, this is a pretty severe issue. Good that you've notices this!

The coverage impact is a downer of course, but you're right of course, there is no point in testing generated code.

mpgirro commented 3 years ago

LGTM 👍

v1.1.0 is ready to be shipped from my perspective.