search

mphowardlab / azplugins

A HOOMD-blue component for soft matter simulations.
BSD 3-Clause "New" or "Revised" License
21 stars 13 forks source link

Authenticate for DockerHub pulls #42

Closed mphoward closed 3 years ago

mphoward commented 4 years ago

Adds DockerHub authentication to CircleCI by storing credentials in a CircleCI context.

Fixes #39

mphoward commented 3 years ago

No problem, this is not urgent. DockerHub will start throttling pulls at the beginning of November, so just need to fix before then. After I merge this into master / develop, make sure to update any branches you have open so they get this fix.

We test against both 2.8.0 and 2.6.0. Do you want to list both?

I've also opened #41 to propose building against only 2.9.3 in a future version.

astatt commented 3 years ago

I think it is perfectly ok to only test against one hoomd-blue version and list the newest one, trailing behind their official tag release a bit, but not too old. We really do not need to keep track of all the different version combinations in the github, unless there is a specific reason you want to test against both 2.6.0 and 2.8.0? If a single user wants to use a specific combination of hoomd-blue version and azplugins version they should execute the unit-tests locally for their build combination anyway. Previously tested combinations are recorded in the changelog as well, so users could find that information. We can be explicit about it and put a sentence in the README.

mphoward commented 3 years ago

I merged this into master. I also updated develop and the two open PRs to use this commit.