Correcting examples in collectives chapter

[mpiforumbot]

Originally by gropp on 2012-03-07 09:30:07 -0600

---

I ran the code checker over the current version of the MPI-3 standard. Attached are my recommended fixes for the collective chapter. This should be considered a chapter committee issue, and is added as a ticket only to capture the issue.

Also notice a comment about a trivial text error in MPI_Op_free, also a chapter committee issue.

Bill

The chapter list doesn't show who is the chapter chair, so I've listed the most likely suspects.

Index: chap-coll/coll.tex
===================================================================
--- chap-coll/coll.tex  (revision 1116)
+++ chap-coll/coll.tex  (working copy)
@@ -1175,7 +1175,8 @@
 \begin{verbatim}
     MPI_Comm comm;
     int gsize,sendarray[100][150],*sptr;
-    int root, *rbuf, stride, myrank, disp[2], blocklen[2];
+    int root, *rbuf, stride, myrank, blocklen[2];
+    MPI_Aint disp[2];
     MPI_Datatype stype,type[2];
     int *displs,i,*rcounts;

@@ -1307,7 +1308,8 @@
 \begin{verbatim}
     MPI_Comm comm;
     int gsize,sendarray[100][150],*sptr;
-    int root, *rbuf, myrank, disp[2], blocklen[2];
+    int root, *rbuf, myrank, blocklen[2];
+    MPI_Aint disp[2];
     MPI_Datatype stype,type[2];
     int *displs,i,*rcounts,num;

@@ -2680,6 +2682,7 @@
 ! global sum
 CALL MPI_REDUCE(sum, c, 1, MPI_REAL, MPI_SUM, 0, comm, ierr)
 RETURN
+END
 \end{verbatim}
 }
 \end{example}
@@ -2716,6 +2719,7 @@

 ! return result at node zero (and garbage at the other nodes)
 RETURN
+END
 \end{verbatim}
 }
 \end{example}
@@ -3257,6 +3261,7 @@
 \end{funcdef}

 \cdeclindex{MPI\_Op}\cdeclindex{MPI::Op}%
+%% WDG 2/14/2012: This should be MPI_Op_free, not MPI_op_free
 \mpibind{MPI\_op\_free(MPI\_Op~*op)}

 \mpifbind{MPI\_OP\_FREE(OP, IERROR) \fargs INTEGER OP, IERROR}
@@ -3443,6 +3448,7 @@

 ! return result at all nodes
 RETURN
+END
 \end{verbatim}
 }
 \end{example}
Williams-MacBook-Pro:MPI-3.0 gropp$ 

[mpiforumbot]

Originally by htor on 2012-03-20 11:31:28 -0500

---

Thanks Bill! All examples are fixed in this chapter. As suggested, I didn't use the messy change macros for those simple and clear changes. Chapter is attached for review by the chapter committee! Please attach reviews to the tickets as comments!

[mpiforumbot]

Originally by htor on 2012-03-20 11:31:54 -0500

---

Attachment added: coll.pdf (677.9 KiB)

[mpiforumbot]

Originally by RolfRabenseifner on 2012-07-14 07:03:57 -0500

---

Review: All is implemented in the approved svn. Ticket can be closed with TEXT COMMITTED.