mpi2 / PhenotypeData

Reorganisation, update, and extend code from PhenotypeArchive
Apache License 2.0
2 stars 5 forks source link

All Data table: on row clicking, data such as "litter" to be shown in context #408

Closed viomunoz closed 3 years ago

viomunoz commented 4 years ago

This ticket replaces ticket #392

Requirements: In the All Data table: we decided that data such as "litter" will be be displayed in context (currently user waits for the data to be displayed and it is never displayed).

i.e. Show ALL data associated to the procedure on the resulting chart page

In this particular case, we would like that on row clicking "average litter size", the user is redirected to the viability chart page where average litter size is shown in context.

Screenshot 2020-07-14 at 14.12.29.png

Screenshot 2020-07-14 at 14.15.03.png

Until this is done, disable the link for the time being?

Example: go to Nrxn1, , filter for "litter" https://www.mousephenotype.org/data/genes/MGI:1096391

Screenshot 2020-07-14 at 14.09.41.png

jmason-ebi commented 3 years ago

Noted that there is some difficulty in that the parameters are not uniform across all procedures so we would need to keep a map for each procedure specific for each data point to show on the chart page.

E9.5 https://www.mousephenotype.org/impress/ProcedureInfo?procID=177 E12.5 https://www.mousephenotype.org/impress/ProcedureInfo?procID=178 E14.5 https://www.mousephenotype.org/impress/ProcedureInfo?procID=179 E18.5 https://www.mousephenotype.org/impress/ProcedureInfo?procID=180

We have a map of this already: https://github.com/mpi2/PhenotypeData/blob/master/data-model/src/main/java/org/mousephenotype/cda/enumerations/EmbryoViability.java

Need to ensure that this is updated with missing percentages parameters (such as IMPC_EVL_019_001).

jmason-ebi commented 3 years ago

Fixed