mpi2 / PhenotypeData

Reorganisation, update, and extend code from PhenotypeArchive
Apache License 2.0
2 stars 5 forks source link

procedureCompleteness report #455

Closed viomunoz closed 3 years ago

viomunoz commented 4 years ago

Background information:

The procedureCompletnesss report, here: ftp://ftp.ebi.ac.uk/pub/databases/impc/all-data-releases/release-12.0/results/ lists, for each allele / colony, attributes for that colony (gene, allele, center, etc.) and:

For each one of these categories, there are 3 columns: Name, Stable ID and Count.

Proposed action items:

    • [x] MP terms that we are listing as succesful are MP hits. To reduce ambiguity, we are changing the wording "Successful" to "Significant". This affects the 3 last columns: "MP Name: Successful", "MP Accession Id: Successful", and "MP Count: Successful".
    • [x] Top-level terms listed as sucessful reflect those procedures that were successful, rather than the MP hits. We need to add Top-level MP terms that are signifcant, i.e. encompassing the MP terms that are significant. Three new columns are needed: "Top-level MP Name: Significant", "Top-level MP Accession Id: Significant", and "Top-level MP Count: Significant".
    • [x] For simplicity, the top-level terms listed as successful could be removed from the report (because of the nateure of the IMPC phenotyping pipeline, the more procedures succesful, the more biological systems examined that were successful), or we could decide to keep. @jmason to provide feedback, please :)
    • [x] Change the procedureCompleteness report name to procedureCompletenessAndPhenotypeHits report.
mrelac-ebi commented 4 years ago

Report updates are complete.

jmason-ebi commented 3 years ago

Keep the top levels. Multiple uses for this data including things like co-occurance maps are made possible by this data. While it is available elsewhere (API) its also nice to have it consolidated here.