mpi2 / PhenotypeData

Reorganisation, update, and extend code from PhenotypeArchive
Apache License 2.0
2 stars 5 forks source link

Viability data in chart pages: IMPC_VIA_002 data, repeated data sets #531

Open viomunoz opened 3 years ago

viomunoz commented 3 years ago

Description of issue: IMPC_VIA_002 data allows to have more than one “Measured value” (and therefore the corresponding “Associated phenotype”) based on the same data / counts. There is no need to show the data more than once when more than one "Measured value" (and "Associated data") are presented. Currently, the same pie charts and table are presented more than once, presumably as many as “Measured value” there are. See this example [1].

Team decided on the following requirements:

Screenshot 2021-02-01 at 22.50.11.png

[1] Screenshot of chart page showing Viability data for an X-linked gene, Fgd1. Note the same pie charts and table appear more than once.

Screenshot 2021-01-29 at 00.23.41.png

jwgwarren commented 3 years ago

Nhsl2

http://localhost:8080/PhenotypeArchive_war/charts?accession=MGI:3645090&parameter_stable_id=IMPC_VIA_001_001&parameter_stable_id=IMPC_VIA_063_001&parameter_stable_id=IMPC_VIA_064_001&parameter_stable_id=IMPC_VIA_065_001&parameter_stable_id=IMPC_VIA_066_001&parameter_stable_id=IMPC_VIA_067_001

shows a chart with hemizygous data 17!!

jwgwarren commented 3 years ago

displays male hemi in pie chart and hemi in male and female table. Need to add hemi male to the male and female pie chart.

jwgwarren commented 3 years ago

For Cib2 we have a blank for the associated phenotype - this is because there is no phenotype from the data whereas others say "no significant association" or something. What do we want to put if there is no associated phenotypes???

jmason-ebi commented 3 years ago

Ongoing

viomunoz commented 3 years ago

Autosomal Nxn

There are two sets of data, they are reported 9 times.