Incompatibility with 3.36 beta

bdaase commented 4 years ago

This extension seems incompatible with the new 3.36 release. You find a lot of these in the journal:

Feb 22 10:09:26 xps-9370 gnome-shell[12124]: JS ERROR: Extension extendedgestures@mpiannucci.github.com: TypeError: Clutter.DeviceManager is undefined
                                             _init@/home/bjoern/.local/share/gnome-shell/extensions/extendedgestures@mpiannucci.github.com/extension.js:41:29
                                             wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:82:27
                                             _Base.prototype._construct@resource:///org/gnome/gjs/modules/script/_legacy.js:18:10
                                             newClass@resource:///org/gnome/gjs/modules/script/_legacy.js:114:21
                                             enable@/home/bjoern/.local/share/gnome-shell/extensions/extendedgestures@mpiannucci.github.com/extension.js:246:22
                                             _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
                                             loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26
                                             _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:536:18
                                             collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
                                             _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:515:19
                                             _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:545:18
                                             _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:576:18
                                             init@resource:///org/gnome/shell/ui/extensionSystem.js:54:14
                                             _initializeUI@resource:///org/gnome/shell/ui/main.js:242:22
                                             start@resource:///org/gnome/shell/ui/main.js:138:5
                                             @<main>:1:47

mpiannucci commented 4 years ago

Thanks for the report!!! I’ll have to look into the changes with clutter

docquantum commented 4 years ago

Gnome shell 3.36 has now been released (arch linux). Just a heads up. Thanks for the amazing work!

Srinivasa314 commented 4 years ago

To support 3.36 make this change in extension.js

if (Clutter.DeviceManager) { //For 3.34 and below let deviceManager = Clutter.DeviceManager.get_default(); this._virtualDevice = deviceManager.create_virtual_device(Clutter.InputDeviceType.KEYBOARD_DEVICE); } else { //for 3.36 let seat = Clutter.get_default_backend().get_default_seat(); this._virtualDevice = seat.create_virtual_device(Clutter.InputDeviceType.KEYBOARD_DEVICE); }

bdaase commented 4 years ago

Thanks @Srinivasa314, works fine for me :)

mpiannucci commented 4 years ago

Awesome @Srinivasa314 ... can you create a pull request for me? I am away from my Linux machine for the next few days but I would love to get the fix in Master

bdaase commented 4 years ago

@mpiannucci I could do it but obviously I would like the credits to got to @Srinivasa314.

mpiannucci commented 4 years ago

@BjoernDaase okay either way I will be sure to credit @Srinivasa314 in the release notes

Srinivasa314 commented 4 years ago

@BjoernDaase, you can do the pull request.

bdaase commented 4 years ago

Here you go: https://github.com/mpiannucci/gnome-shell-extended-gestures/pull/79

mpiannucci commented 4 years ago

Thank you!!!!

mpiannucci / gnome-shell-extended-gestures

Incompatibility with 3.36 beta #76