search

mpiannucci / react-native-context-menu-view

Use native context menus in React Native
MIT License
668 stars 69 forks source link

Migrate to New Architecture #49

Open mpiannucci opened 2 years ago

mpiannucci commented 2 years ago

Tracking issue for migrating the package to use the New Module Architecture: https://github.com/reactwg/react-native-new-architecture/blob/main/docs/enable-libraries-prerequisites.md

UPDATE 8/8/2024: After testing the example app in new architecture mode the library seems to work ok. I am leaving this open as tracking issue for updating to the fabric and turbomodule apis. If there are issues with using as is in a new architecture app, please mention you issues here

anton-patrushev commented 7 months ago

any progress here?

castdrian commented 5 months ago

doesn't look like it

elsa17z commented 3 months ago

This is 1 of the 17 packages I have that currently do not support new architecture, commenting to keep myself posted

yzhe554 commented 2 months ago

Any update for this issue?

castdrian commented 2 months ago

just use tamagui or something

mpiannucci commented 2 months ago

I do want to migrate to new architecture..

But there isn't really a performance hit for this project on your app, so it's not like you're going to get some crazy improvement from it going new architecture. I understand why everyone wants it, but it's going to take me time to do so and I don't have a lot of it.

castdrian commented 2 months ago

Well your package is simply broken for all recent projects, hence just use tamagui people or similar pure js libs

mpiannucci commented 2 months ago

Well your package is simply broken for all recent projects, hence just use tamagui people or similar pure js libs

Is it actually broken? If so can you post an error? I just did a test on ios and it is working fine for me in bridgeless mode

Screenshot 2024-08-08 at 2 01 23 PM

mpiannucci commented 2 months ago

marked compatible after testing: https://github.com/react-native-community/directory/pull/1236