search

mpicard / pyvas

OpenVAS Management Protocol Client for Python
MIT License
23 stars 10 forks source link

Improper Python source encoding definitions. #13

Closed scotmatson closed 6 years ago

scotmatson commented 6 years ago

https://www.python.org/dev/peps/pep-0263/

Noticed the use of encoding definitions in each file is a bit varied and doesn't have uniformity across the project and in some cases violates the standard.

Usage: # coding: utf-8 or # -*- coding: utf-8 -*-

A minor thing, but something that jumped out to me. Great project by the way, was about to build this myself then stumbled across this Python3-friendly repo. Just wish it was more active :)

mpicard commented 6 years ago

Thanks for letting me know! I’ll update it today On Thu, Jan 11, 2018 at 10:53 PM Scot Matson notifications@github.com wrote:

https://www.python.org/dev/peps/pep-0263/

Noticed the use of encoding definitions in each file is a bit varied and doesn't have uniformity across the project and in some cases violates the standard.

Usage:

coding: utf-8 or # -- coding: utf-8 --

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mpicard/pyvas/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHYRvgACFbbALVDIboNhRw54ILl_vWpks5tJpDKgaJpZM4RbkkO .

mpicard commented 6 years ago

@scotmatson I'm always open to PRs! I need some here for sure. I haven't been doing any openvas stuff at work so I have zero time to work on it. Feel free to add whatever is missing. I obviously have a lot of API surface in OMPv8/9 that isn't covered. I also would love to setup CI with docker image of openvas but haven't gotten around to it

scotmatson commented 6 years ago

I recently returned to OpenVAS after being sidelined with another project so I will likely be looking towards Pyvas again soon.

Recently setup a PoC of a distributed OpenVAS network via AWS EC2 & Portainer using https://github.com/mikesplain/openvas-docker as our foundation. Mike did an excellent job putting together an up-to-date docker image.

mpicard commented 6 years ago

Yeah haven't had any time to setup a container for openvas but i'd love to run the unit tests in travis against a container. I think i'd make the project more open to contributions if you didn't have to setup openvas locally to write/run unit tests. Or we could use docker locally in addition.