mpicard / pyvas

OpenVAS Management Protocol Client for Python
MIT License
23 stars 10 forks source link

Running tests #17

Closed ghost closed 6 years ago

ghost commented 6 years ago

I'm having trouble running the tests. I've got it to the point where I can run pytest on it, but it fails. I have a working OpenVAS instance and the host I'm trying to run the tests on can talk to it successfully with omp. I wonder if you have any advice on getting this to run successfully please?

This is what I get when I run it with python3 -m pytest from a fresh clone of your repo. results.txt

Thanks!

Anna

ghost commented 6 years ago

Sorry, I've sorted this out now.

mpicard commented 6 years ago

Cool! It should be env vars iirc On Tue, May 15, 2018 at 2:44 PM Anna Langley notifications@github.com wrote:

Sorry, I've sorted this out now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mpicard/pyvas/issues/17#issuecomment-389171725, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHYRit5V4gm480gu99QHQPs_mh8zNxgks5tytvKgaJpZM4T7saK .

ghost commented 6 years ago

It was a combination of that and packages. I've been keeping track of what I've done. Now I'm working on writing tests for all the functions that I've written...

mpicard commented 6 years ago

Awesome! That’s great news I’m sorry I don’t have the time this project deserves at the moment so I glad someone is adding more functionality and tests! On Tue, May 15, 2018 at 4:53 PM Anna Langley notifications@github.com wrote:

It was a combination of that and packages. I've been keeping track of what I've done. Now I'm working on writing tests for all the functions that I've written...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/mpicard/pyvas/issues/17#issuecomment-389218155, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHYRklIoaHSuZ1c2KgB-4kszdMIhIY1ks5tyvnlgaJpZM4T7saK .

ghost commented 6 years ago

Thanks Martin!

A bit of background about what I’m doing, for your information. We have a system that was built around Nessus using it’s REST API, which automates setting up scans and policies, and then presents the results over the web to the people responsible for the machines that have been scanned. Nessus is both changing its licensing model, and removing the API, so it will soon be untenable (pun intended) to carry on in this manner. In the short term, I’m working on replacing Nessus with OpenVAS, which involves rewriting the components of our system to interface with OpenVAS, which demands more functionality than pyvas currently offers, so I’m working on that too.

One thing that Nessus does is refer to things by name rather than ids. So rather than put a lot of awkward logic into my scripts, I’m trying to do it only once by creating _by_name functions in pyvas, that mimic this.

Thank you for developing pyvas and sharing it with the world, it’s making my life a lot easier than it would have been otherwise!

Anna

On 15 May 2018, at 20:31, Martin Picard notifications@github.com wrote:

Awesome! That’s great news I’m sorry I don’t have the time this project deserves at the moment so I glad someone is adding more functionality and tests! On Tue, May 15, 2018 at 4:53 PM Anna Langley notifications@github.com wrote:

It was a combination of that and packages. I've been keeping track of what I've done. Now I'm working on writing tests for all the functions that I've written...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/mpicard/pyvas/issues/17#issuecomment-389218155, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHYRklIoaHSuZ1c2KgB-4kszdMIhIY1ks5tyvnlgaJpZM4T7saK .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mpicard/pyvas/issues/17#issuecomment-389286112, or mute the thread https://github.com/notifications/unsubscribe-auth/AkrpugfjZ80I3JL8Bl0k_rmYyGnU0d0nks5tyy0jgaJpZM4T7saK.

mpicard commented 6 years ago

Very cool! I was doing something similar with a REST based service that needed to talk to openvas but found nothing that worked so I created this and I’m glad it’s of help to you! Your privnote expired but you can email me at martin8768@gmail.com or I’ll leave this Issue open for discussion. Unfortunately I moved on to other things so I don’t have the time but I’m so happy to hear that there is enough core functionality to easily let other contributors add more command support and higher level APIs.