mpicbg-scicomp / gearshifft

Benchmark Suite for Heterogenuous FFT Implementations
Apache License 2.0
34 stars 9 forks source link

Use modern cmake. #124

Closed tdd11235813 closed 5 years ago

tdd11235813 commented 6 years ago

Starting to modernize cmake files. Also created a develop branch on upstream, so we can manage rollout of new versions (next milestone 0.4.0). (following trunkbaseddevelopment.com)

Changelog 0.4.0:

...

tdd11235813 commented 6 years ago

Another WIP stage. Open for testing.

tdd11235813 commented 5 years ago

ready for merge, I think :)

psteinb commented 5 years ago

a lot of code to review. From scanning it, it looks very good. I feel an urge to just merge. I'll test locally first anyhow.

tdd11235813 commented 5 years ago

yeah ok testing is a good thing, it is likely, that there are glitches.

tdd11235813 commented 5 years ago

Incorporated rocFFT backend. Tested on AMD/HCC platform. No support for rocFFT/hipFFT->cuFFT at the moment. Fixed some other stuff. Superbuild is more flexible now, as external libraries can be kept in build folder (while downloads are always externally to avoid redownloading). As rocFFT requires HCC on AMD, other backends might be build with a different compiler in a different build folder. However, packaging is currently not aware of that, as cmake does not allow to switch compiler during build generation. With superbuilds it is possible to cover that, however packaging is currently not part of the superbuild layer. Currently, with superbuild, one still has to go down into gearshifft-build to call make package.

Edit: see subsequent commits. Refactored superbuild to make multi-arch packaging possible. Still some work to do for travis.

tdd11235813 commented 5 years ago

travis tests passed. Readme updated. Going to self-merge (gearshifft to v0.4.0). Edit: still needs some testing, of course ;)