Open emmenlau opened 5 years ago
... ok, well, I will provide a separate FFTWWrappers cmake options set though. I do not like the current mixed FFTW and FFTWWrappers cmake code.
Great, thanks a lot! I'm curious to test FFTWWrappers on MacOS X, looking forward!
I'm having a bit of trouble with the MacOSX build and
GEARSHIFFT_BACKEND_FFTW_THREADS
. There are two things that may be suboptimal:GEARSHIFFT_BACKEND_FFTW_THREADS
that seems to be triggered forFFTW
andFFTWWrappers
. Is this intentionally? I would assume that the libraries require separate flags since they do not necessarily share any properties, or am I on the wrong track(?)in inc/libraries/fftw/fftw.hpp:381. Since I have
GEARSHIFFT_BACKEND_FFTW_THREADS
not set on MacOSX, cmake creates the compiler define as-DGEARSHIFFT_BACKEND_FFTW_THREADS=""
. Apple Clang does not seem like this combination, it complains abouterror: invalid token at start of a preprocessor expression
. I guess this needs some sort of resolution. I could think of several simple workarounds, like definingGEARSHIFFT_BACKEND_FFTW_THREADS
as0
or1
instead of empty, or other similar solutions. Do you have a specific preference?