Bad uses of readTVarIO - Githubissues

mpickering / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Closed mpickering closed 4 years ago

mpickering commented 5 years ago

Using TVars rather than MVars opened up a lot of potential races.

[x] runDeferredActions - readMTS and modifyMTS = RACE
[x] HasGhcModuleCache API in terms of get/set is unsafe (see IdeM implementation)
[x] hh function in haskell-lsp - Read followed by modify
[x] handleMessageWithConfigChange - Read followed by modify
[x] publishDiagnostics - read/write could clobber update
[x] flushDiagnosticsBySouce read/write
[x] initializeRequestHandler read/write

mpickering commented 5 years ago

mpickering commented 5 years ago

fendor commented 4 years ago

Close as all of these have been merged.