mpickering / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Apply hlint refactor remove unrelated code #77

Closed jneira closed 4 years ago

jneira commented 4 years ago

When i tried to aplly the refactor using the light bulb:

hie-bad-refactor

It has removed imports and the function above the one with the redundant brackets (but it removed the brackets as well 😆 )

Maybe related #1448

jneira commented 4 years ago

I've collected some data about here:

The temp files has unix line endings instead windows ones, so maybe it is related with the bug. Otoh other document changes (replace a unknown symbol or a typed hole) works wit actual line endings :thinking:

jneira commented 4 years ago

As @mpickering suggested i'll test it in master and i'll try to fix there if that is the case

jneira commented 4 years ago

Confirming the behavior is reproduced in master so i'll try to fix there. Keeping the issue here, nevertheless, let me know if you prefer to move it to the main repo

fendor commented 4 years ago

Let's create a reference to it in master, so others can dig in and we can't accidentally forget it. Also, so that people can see that the bug is already known!

jneira commented 4 years ago

Closing this one here