search

mpickpt / mana

MANA for MPI
35 stars 24 forks source link

Fix memory range #328

Closed dahongli closed 1 year ago

dahongli commented 1 year ago

The memory layout is changed when no_randomize is enabled. The assumption that lower half would be 1GB below stack region is not valid anymore. This change uses region below minHighMemStart as the lower half.

This change has to used with Gene's DMTCP PR #1063 ADDR_NO_RANDOMIZE.

gc00 commented 1 year ago

@dahongli, I just realized that, either as a commit in this new PR or in a new PR, we need to add the --mpi flag to dmtcp_launch in bin/mana_launch. On line 182 of bin/mana_launch, we can add it. We can also add --mpi in each of the comments that refers to dmtcp_launch.

dahongli commented 1 year ago

@gc00 I will file a new PR for adding --mpi to mana_launch. The dashboard automation tests use the dmtcp_launch. I will sync up with Tom to add --mpi flag when using dmtcp_launch.