search

mpickpt / mana

MANA for MPI
35 stars 24 forks source link

Updated DMTCP to latest master. #362

Closed karya0 closed 1 year ago

karya0 commented 1 year ago

The latest DMTCP will now have DMTCP munmap the text/data/heap of mtcp_restart. MANA will not need to worry about this in mtcp_plugin_skip_memory_region_munmap. We can then update mtcp_plugin_skip_memory_region_munmap when this is pushed into main.

JainTwinkle commented 1 year ago

@karya0 I would like to hold this PR until #361 gets merged. It is because one of the commits in this PR changes the rinfo data structure.

karya0 commented 1 year ago

How close are we to merging #361? Asking because this PR is blocking me from providing an updated API for restart plugins that is complementary to 361. If there is still some time until 361 can be pushed, then let's push this PR now and update 361 accordingly.

JainTwinkle commented 1 year ago

@karya0 It's close to getting approved and merged (most likely, by the end of the day).

karya0 commented 1 year ago

Perfect. I’ll wait until it’s merged

On Tue, Sep 12, 2023 at 2:27 PM JainTwinkle @.***> wrote:

@karya0 https://github.com/karya0 It's close to getting approved and merged (most likely, by the end of the day).

— Reply to this email directly, view it on GitHub https://github.com/mpickpt/mana/pull/362#issuecomment-1716474302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJ4YQD2KUKBUVMJPRVM2DX2DHSXANCNFSM6AAAAAA4VMWX7M . You are receiving this because you were mentioned.Message ID: @.***>

gc00 commented 1 year ago

@karya0 , I also want to get #361 merged.. @JainTwinkle is dong a second review of PR #361 now. I also want to push it in soon, to have a standard platform in the main branch.

gc00 commented 1 year ago

And PR #361 is now merged.

karya0 commented 1 year ago

@gc00, @JainTwinkle : Can you approve this PR so we can do a quick merge?