search

mpievolbio-scicomp / rarefan

http://rarefan.evolbio.mpg.de
MIT License
1 stars 0 forks source link

Check submitted data #46

Closed CFGrote closed 1 year ago

CFGrote commented 1 year ago

Run zo6ctgd4 (rerun of gvnnqk79): Submitted data is a protein fasta. java starts but hangs on reporting "Wrong letter in DNA sequence".

Need to check if all submitted fenomes are NA sequences, not proteins or anything else and report proper error message to user if not.

fredeBio commented 1 year ago

I will look into it!

----- Original Message ----- From: "Carsten Fortmann-Grote" @.> To: "mpievolbio-scicomp/rarefan" @.> Cc: "Subscribed" @.***> Sent: Tuesday, December 20, 2022 12:57:00 PM Subject: [mpievolbio-scicomp/rarefan] Check submitted data (Issue #46)

Run zo6ctgd4 (rerun of gvnnqk79): Submitted data is a protein fasta. java starts but hangs on reporting "Wrong letter in DNA sequence".

Need to check if all submitted fenomes are NA sequences, not proteins or anything else and report proper error message to user if not.

-- Reply to this email directly or view it on GitHub: https://github.com/mpievolbio-scicomp/rarefan/issues/46 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

fredeBio commented 1 year ago

Hey Carsten, I just submitted this job. So I guess the problem is not fixed yet: http://rarefan.evolbio.mpg.de/results?run_id=1q497hyd Can you let me know when you update rarefan (and maybe also when you integrate the DNA sequence checking?). So I can tell our reviewers that we fixed the issue?

CFGrote commented 1 year ago

no it's not on the web server yet. i'm currently testing your changes locally, if everything works i'll push it to the server.

fredeBio commented 1 year ago

Thanks! ----- Original Message ----- From: Carsten Fortmann-Grote @.> To: mpievolbio-scicomp/rarefan @.> Cc: fredeBio @.>, Comment @.> Sent: Wed, 21 Dec 2022 09:08:05 +0100 (CET) Subject: Re: [mpievolbio-scicomp/rarefan] Check submitted data (Issue #46)

no it's not on the web server yet. i'm currently testing your changes locally, if everything works i'll push it to the server.

-- Reply to this email directly or view it on GitHub: https://github.com/mpievolbio-scicomp/rarefan/issues/46#issuecomment-1360981305 You are receiving this because you commented.

Message ID: @.***>

CFGrote commented 1 year ago

Done by merging #47

fredeBio commented 1 year ago

Vielen Dank Carsten! Ich schreibe ihnen jetzt eine email.

----- Original Message ----- From: "Carsten Fortmann-Grote" @.> To: "mpievolbio-scicomp/rarefan" @.> Cc: "Frederic Bertels" @.>, "Comment" @.> Sent: Wednesday, December 21, 2022 3:45:59 PM Subject: Re: [mpievolbio-scicomp/rarefan] Check submitted data (Issue #46)

Done by merging #47

-- Reply to this email directly or view it on GitHub: https://github.com/mpievolbio-scicomp/rarefan/issues/46#issuecomment-1361417343 You are receiving this because you commented.

Message ID: @.***>

fredeBio commented 1 year ago

Ach ja, wir sollten wahrscheinlich noch eine Funktion einbauen, die Jobs killed, die länger als 3h laufen.

----- Original Message ----- From: "Frederic Bertels" @.> To: "mpievolbio-scicomp" @.> Sent: Wednesday, December 21, 2022 3:52:27 PM Subject: Re: [mpievolbio-scicomp/rarefan] Check submitted data (Issue #46)

Vielen Dank Carsten! Ich schreibe ihnen jetzt eine email.

----- Original Message ----- From: "Carsten Fortmann-Grote" @.> To: "mpievolbio-scicomp/rarefan" @.> Cc: "Frederic Bertels" @.>, "Comment" @.> Sent: Wednesday, December 21, 2022 3:45:59 PM Subject: Re: [mpievolbio-scicomp/rarefan] Check submitted data (Issue #46)

Done by merging #47

-- Reply to this email directly or view it on GitHub: https://github.com/mpievolbio-scicomp/rarefan/issues/46#issuecomment-1361417343 You are receiving this because you commented.

Message ID: @.***>