search

mpievolbio-scicomp / rarefan

http://rarefan.evolbio.mpg.de
MIT License
1 stars 0 forks source link

Report table if Analyse REPINs is off. #48

Closed CFGrote closed 1 year ago

CFGrote commented 1 year ago

The results table is messed up if analyse repins is switched off. the rows are misaligned, first counts appear in the header row. Example is run ajwtiy4s.

fredeBio commented 1 year ago

To me the table seems fine. There are just columns missing. The same for analysis with REPINs.

----- Original Message ----- From: "Carsten Fortmann-Grote" @.> To: "mpievolbio-scicomp/rarefan" @.> Cc: "Subscribed" @.***> Sent: Wednesday, January 11, 2023 11:18:48 AM Subject: [mpievolbio-scicomp/rarefan] Report table if Analyse REPINs is off. (Issue #48)

The results table is messed up if analyse repins is switched off. the rows are misaligned, first counts appear in the header row. Example is run ajwtiy4s.

-- Reply to this email directly or view it on GitHub: https://github.com/mpievolbio-scicomp/rarefan/issues/48 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

CFGrote commented 1 year ago

The group index is taken from the presAbs_*.txt filenames (presAbs_1.txt becomes Group 1 etc.). The files are sorted alphabetically, so presAbs_10.txt comes before presAbs_2.txt etc. Since we only report the first 12 groups (not sure where that is configured), many groups seem to be missing, but they are actually in the database. Guess this can be fixed by sorting filenames numerically, right? How many groups should we put into the table if there are many?

fredeBio commented 1 year ago

I see. Interesting. Yeah, I think we can fix it by doing a numerical sort. I think 9 groups would be good. Similar to the plot. Maybe we can also only plot the groups that contain data. So the first page corresponds to the plots.

----- Original Message ----- From: "Carsten Fortmann-Grote" @.> To: "mpievolbio-scicomp/rarefan" @.> Cc: "Frederic Bertels" @.>, "Comment" @.> Sent: Wednesday, January 11, 2023 11:52:03 AM Subject: Re: [mpievolbio-scicomp/rarefan] Report table if Analyse REPINs is off. (Issue #48)

The group index is taken from the presAbs_*.txt filenames (presAbs_1.txt becomes Group 1 etc.). The files are sorted alphabetically, so presAbs_10.txt comes before presAbs_2.txt etc. Since we only report the first 12 groups (not sure where that is configured), many groups seem to be missing, but they are actually in the database. Guess this can be fixed by sorting filenames numerically, right? How many groups should we put into the table if there are many?

-- Reply to this email directly or view it on GitHub: https://github.com/mpievolbio-scicomp/rarefan/issues/48#issuecomment-1378565564 You are receiving this because you commented.

Message ID: @.***>

CFGrote commented 1 year ago

Finally fixed by d99e329a3 and 12dd26dc.

CFGrote commented 1 year ago

After the fix, rerunning ajwtiy4s yields proper sorting of groups.