search

mpimd-csc / flexiblas

FlexiBLAS - A BLAS and LAPACK wrapper library with runtime exchangeable backends. This is only a mirror of https://gitlab.mpi-magdeburg.mpg.de/software/flexiblas-release
https://www.mpi-magdeburg.mpg.de/projects/flexiblas
GNU Lesser General Public License v3.0
36 stars 7 forks source link

Int instead of int in standalone API #21

Closed Enchufa2 closed 2 years ago

Enchufa2 commented 2 years ago

I've noticed that a number of functions have changed from int to Int in flexiblas_api.h. They are equal per the define on top of that header, but shouldn't this change in flexiblas_api_standalone.c too?

grisuthedragon commented 2 years ago

Since some of the (the ones with _ in the end) are meant to be called from Fortran, and thus affected by the 64 bit integer setting, they must return Int instead of int but you are right, this behaviour should be reflected by flexiblas_api_standalone.c.

This will be included in the next bugfix release, when ever it is ready. For now, you can leave it as it is,

Enchufa2 commented 2 years ago

Perfect. I include flexiblas_api_standalone.c in the R package here. Should I patch it there to match the header?

grisuthedragon commented 2 years ago

fixed in 3.1.3.