mpio-be / rangeMapper

A platform for the study of macroecology of life history traits
https://mpio-be.github.io/rangeMapper
8 stars 3 forks source link

Futures: Don't use 'transparent' (use 'sequential') + 'multiprocess' is deprecated #8

Closed HenrikBengtsson closed 3 years ago

HenrikBengtsson commented 3 years ago

Hi. As part of taking the future package to the next level, I'm narrowing down what futures may do. This is mostly backward compatible, but one thing that needs to go is the support for future(..., local = FALSE). Most of this has already been done, cf. https://github.com/HenrikBengtsson/future/issues/382. However, it is still used internally by transparent futures, which I'll keep supporting for a while, but they should only be used for debugging and troubleshooting purposes. They should never for production use The reason for this is that local = FALSE introduces behavior that is an outlier in the future framework. (This will be clarified further in the next release of future).

I spotted that rangeMapper uses 'transparent' futures in processRanges():

https://github.com/mpio-be/rangeMapper/blob/8e4800bb8a301aa45fc15e0667aa2b56a4422638/R/MapProcess-methods.R#L43-L48

valcu commented 3 years ago

Fixed! As suggested all parallel support setup is fully under the the user's control.

HenrikBengtsson commented 3 years ago

Thank you