search

mpizenberg / elm-solve-deps

A dependency solver for the elm ecosystem
Mozilla Public License 2.0
5 stars 0 forks source link

Merge `elm-solve-deps-wasm` back here #9

Open lishaduck opened 1 month ago

lishaduck commented 1 month ago

Custom profiles address rust-lang/cargo#8264 and rust-lang/cargo#4897 well enough that breaking this out into a separate repository should no longer be necessary. If we care about the (very short) commit history, https://hacks.mozilla.org/2022/08/merging-two-github-repositories-without-losing-commit-history/ is quite helpful.

Just filing this in case we'd like to merge these back together. Personally, I'd prefer it, but I'm just a random person on the internet who has no business dictating the structure of this project.

mpizenberg commented 1 month ago

Ah, thanks for the feedback! Yeah I think we can merge both if profiles can be handled separately now. I don’t really care about the commit history. I could just archive the wasm package after a final commit saying things have moved here. But I also don’t mind if it’s easy to merge both history.

lishaduck commented 1 month ago

Ah, thanks for the feedback! Yeah I think we can merge both if profiles can be handled separately now.

Well, to be clear, they aren't technically handled separately, but it can be worked around easily enough.

I don’t really care about the commit history.

Yeah. There's only a few commits there.

I could just archive the wasm package after a final commit saying things have moved here.

Sounds good. Let's wait until my PRs are finished though, if you don't mind. I'd prefer not to redo it all.

But I also don’t mind if it’s easy to merge both history.

It's not awful, but I botched the first few times I tried it, I wouldn't waste the effort on 5 or so migrate to repo 1 and the back commits.