search

mpizenberg / elm-test-rs

Fast and portable executable to run your Elm tests
BSD 3-Clause "New" or "Revised" License
81 stars 13 forks source link

combine #[cfg(...)] for templates into macro #46

Closed harrysarson closed 3 years ago

harrysarson commented 3 years ago

hopefully makes the logic easier to read and maintain

mpizenberg commented 3 years ago

Sorry for the multiple notifications and thanks for the refactor! That's indeed cleaner and easier to follow. If you don't have things to add, that's ready for merge.

harrysarson commented 3 years ago

Is it a problem that CI fails?

mpizenberg commented 3 years ago

MacOS tests are failing when CI loads the cache, I don't know why. If you look at the first CI results on you commit, you'll see that MacOS tests were passing. It's a bit annoying and if you know why, fixing it would be awesome but we can fix it in another PR

harrysarson commented 3 years ago

Let's merge then 👍