search

mpl-extensions / mpl-interactions

Sliders to control matplotlib and other interactive goodies. Works in any interactive backend and even uses ipywidgets when in a Jupyter notebook
https://mpl-interactions.rtfd.io
BSD 3-Clause "New" or "Revised" License
132 stars 20 forks source link

joss review: writing comments #282

Closed ianhi closed 1 year ago

ianhi commented 1 year ago

From @flekschas in https://github.com/openjournals/joss-reviews/issues/5651#issuecomment-1641072224

the choices it makes are not always optimal for scientific plotting

This statement is fairly strong but unjustified. The authors should either give a definition + example of what optimality for scientific plotting means and why ipywidgets does not support it. Or alternatively remove this statement.

I definitely agree that this is currently unjustified in the paper. The differences referred to are laid out here: https://mpl-interactions.readthedocs.io/en/stable/comparison.html#differences-in-generated-widgets Would you find these differences in generated widgets to be convincingly better for interactively plotting scientific models?

y_data = logistic_growth(t_data, L=5, k=1, t0=1) + rng.normal(size=t_data.size, scale=0.

This line is cut off

good catch, will reformat the code.

This framework makes it easy generate complex interactive visualizations

A to is missing after easy

thank you.

Complete Tutorials, Examples, and API documentation are available on https://mpl-interactions.readthedocs.io/en/stable/

Why are Tutorials and Examples examples capitalized here?

will correct

flekschas commented 1 year ago

I definitely agree that this is currently unjustified in the paper. The differences referred to are laid out here: https://mpl-interactions.readthedocs.io/en/stable/comparison.html#differences-in-generated-widgets Would you find these differences in generated widgets to be convincingly better for interactively plotting scientific models?

Even though this is software-focused paper, the paper still needs to justify statements. You could link to the comparison but to be honest I'm not convinced that the comparison justifies the statement about optimality. I would just focus on the three key features that are laid out in the comparison: improved re-rendering performance, portability, and convenience (for when frequent re-rendering is needed). Those are concrete features for which you have convincing arguments that mpl-interactions improves over ipywidgets. Whether those three features define optimality for scientific plotting is a different question that you could only answer by conducting a user study or survey.

ianhi commented 1 year ago

This should all be resolved by https://github.com/mpl-extensions/mpl-interactions/pull/260/commits/e79a7b520fbb92a27a6f8d1542453f4007047d9a feel free to re-open if not