search

mpl-extensions / mpl-interactions

Sliders to control matplotlib and other interactive goodies. Works in any interactive backend and even uses ipywidgets when in a Jupyter notebook
https://mpl-interactions.rtfd.io
BSD 3-Clause "New" or "Revised" License
132 stars 20 forks source link

Joss review: authorship #283

Closed ianhi closed 1 year ago

ianhi commented 1 year ago

from @rgerum in: https://github.com/openjournals/joss-reviews/issues/5651#issuecomment-1634353639

The only checkmark I haven't set yet is about the list of authors (Contribution and authorship). There are a good number of other contributors listed in the github repository readme that do not appear as authors of the paper. Also Doeke Hekstra does not appear in the contributor list in the reposiotires readme. Could the author elaborate on the reasons for this?

from @flekschas:

I agree with @rgerum here. Several contributors with substantial contributions (e.g., with more than 10 commits) are not listed as an author but Doeke Hekstra with zero code contributions is listed as an author. Clarification is needed.

(e.g., with more than 10 commits)

A small note re commits is that these are not a perfect measure as at some point in the repositories history I switched to squash merging from merging the branch with all commits.

Doeke Hekstra

Doeke (@DHekstra) has not contributed code to this project, however he was integral to the genesis of the project. We were analyzing data together, and our discussions of how best to visualize the data and our models are what led to this package. To us this felt like a significant intellectual contribution.

Other contributors

There are many contributors of small fixes, features, or bug reporters. I've done my best to encourage this and also acknowledge these people in the github readme. Regarding authorship, we weren't sure quite what the bounds of appropriate authorship were and if they could include a focus on single features and or documentation vs overall structure of the package. I definitely prefer to be more inclusive than exclusive in authorship. I would propose adding @jrussell25, @redeboer and @samanthahamilton as authors who put in sustained effort to various aspects of the package.

rgerum commented 1 year ago

as you already have a section in the readme to thank everyone who did some contributions it would be good to add Doeke Hekstra there if he was an integral part of the project.

If these other authors have put in enough effort according to you, they should be authors of the paper I think. I will change my review accordingly when this is implemented.

flekschas commented 1 year ago

I agree with @rgerum.

ianhi commented 1 year ago

bump to @jrussell25 @redeboer @samanthahamilton re authorship of the joss paper. If you are interested in being added to the author list please try to let me know by Monday August 14. Happy to talk offline (as it were) as well - you can email me ianhuntisaak at harvard.edu

jrussell25 commented 1 year ago

I'd be very happy to be included as an author!

redeboer commented 1 year ago

Thank you for the invitation @ianhi! I appreciate it, but feels like piggybacking if I were to be listed there ;) Happy to help reviewing a draft or so though

ianhi commented 1 year ago

Ok @redeboer if you do change your mind please let me know. It would not feel like piggybacking to me, you put in sustained effort and added real value :)

ianhi commented 1 year ago

I've included John as an author https://github.com/mpl-extensions/mpl-interactions/pull/260/commits/fe8f16908248cc4b44424f4431a0520605b09d9d

and from my perspective both @samanthahamilton and @redeboer are both welcome to change their minds at any point until the paper is published.