search

mplewis / csvtomd

📝📊 Convert your CSV files into Markdown tables.
MIT License
655 stars 90 forks source link

Allow blank lines and comments #8

Closed lowcloudnine closed 7 years ago

lowcloudnine commented 8 years ago

I was using csvtomd for some csv files and as the files got longer I wanted to add blank lines and comments to increase readability. Added the ability to csvtomd as it was fairly trivial.

Then saw previous pull request about concerns about blank lines and resolved those, it is now optional. Also converted to unittest and added tests for blank lines. The program can also run in python 2.7 and 3.4, 3.5.

mplewis commented 7 years ago

Hi @murphyke. Thanks for your submission – sorry it took me so long to get back to you.

I've thought about the blank lines suggestion and prefer to keep the behavior as-is for empty lines to mimic Python's csv module. You can find my reasoning in #3.

I also don't want to introduce comment support at this time. I wasn't able to find any kind of ad-hoc comment standard in how people use CSV files.

Finally, the work you did in testing six months ago is great and looks great! But I managed to clean up the code, make it testable, and modularize it enough that testing should be less of a pain in the future.

Sorry – but thank you for your code! I appreciate the love for csvtomd. 🌄