og:image not linked to media

mplodowski / seomanager-plugin-public

https://octobercms.com/plugin/renatio-seomanager

4 stars 1 forks source link

og:image not linked to media #26

Closed remko-key closed 2 years ago

remko-key commented 2 years ago

It looks like the og:image field is now set as a media finder field. This is causing two issues:

og:image should be <meta property="og:image" content="{{ seoTag.og_image | media }}"> | media is missing in the seotags/default.htm
The width and height are empty and not calculated.

mplodowski commented 2 years ago

Fixed in version 4.0.0

vshepel commented 2 years ago

Fixed in version 4.0.0

twitter:image missed

mplodowski commented 2 years ago

Fixed in version 4.02.

thedoofus commented 2 years ago

Will the fix be getting applied to version 3?

thedoofus commented 2 years ago

Can I suggest resolving the og_image path in the component rather than using the twig media function?

This is because if you overwrite the og_image in the seo.beforeComponentRender event, and set it to a path for an image that's not in the media library, such as an image uploaded with the fileupload form field. Then the twig media function isn't going to resolve the correct path.