search

mplp / docassemble-mlhframework

A docassemble extension.
Other
0 stars 0 forks source link

Fix share screen and result page buttons #109

Closed ekressmiller closed 4 months ago

ekressmiller commented 5 months ago

These screens still show "Click "Next"" instead of "Tap "Continue"".
image image

I think we tried to fix this here but it doesn't seem to be working.

But I actually think it might be better if these buttons did NOT say "undo" since that might make it sound like you can undo your sharing, which you cannot. Maybe we just don't want a back button on these pages? Is that possible? Will back button: False do anything?

In a perfect world, the back button label on this page might in fact say back, since there's nothing to undo. image

But it looks like the framework tried to set the back button label to something else and it's not having any effect. image

normon66 commented 4 months ago

Regarding the "Thanks for Sharing" / "Your message is on its way" pages (see al_share_results): it looks like the reason that is not working is because mlh_visual.yml (where the change was coded) was never included into mlh_interview_framework.yml: image Navigational buttons could be configured there and that file included into the framework.

ekressmiller commented 4 months ago

good catch @normon66 !

normon66 commented 4 months ago

Caught my own bug, but at least it got caught!