Saving and navigation - Githubissues

mplp / docassemble-mlhframework

A docassemble extension.

Other

0 stars 0 forks source link

Saving and navigation #114

Closed ekressmiller closed 4 months ago

ekressmiller commented 4 months ago

Combine saving and navigation screens into one to reduce number of intro screens; and reduce word count throughout.

Leaving the old version intact for now so that we don't break the live interview when we update.
deleted custom header sizing we had added because it wasn't giving enough differentiation between header levels
I also think the "Using this tool" name would now fit better for this screen, so I stole it and renamed MLH_intro_time.

ekressmiller commented 4 months ago

@normon66 Unfortunately Docassemble does a weird thing with header sizes, and the standard workaround is to manually change the header styles using that class= thing to adjust the size as needed. Shouldn't just change the header level itself for screen-reader accessibility reasons.

With the H5 class styling, I think the size distinction is pretty good, and similar to your suggestion (see below). (Note, this may not have shown up correctly for you during testing. I've been banging my head against the wall for the last 45 minutes trying to figure out what was happening and it turned out I needed a hard refresh to update the css.)

normon66 commented 4 months ago

I figured something like that is why you were including the class attributes. I should have mentioned that in my earlier comment, the point of which was just to make note of the sizing.

The class definitions were oddly not making any difference for me, even though I know I tried a Ctrl+F5 at one point.

All that said, I'm glad that the H5 approach is working correctly! Therefore, my original comments can be disregarded. Thanks!

ekressmiller commented 4 months ago

Yeah, the way the CSS was set up it was overriding any changes to the header class, and since the framework yml updated but the CSS didn't update without a hard refresh, it was very confusing to figure out what was happening! Thanks for your comments as always!