search

mplp / docassemble-mlhframework

A docassemble extension.
Other
0 stars 0 forks source link

Remove redundant alt text on logo #52

Closed BryceStevenWilley closed 10 months ago

BryceStevenWilley commented 10 months ago

A change suggested by an accessibility audit on another Assembly Line project.

Related to https://github.com/SuffolkLITLab/docassemble-AssemblyLine/issues/795

ekressmiller commented 10 months ago

Looks good to me based on the explanation on the AL issue. I guess my only question is are we confident we only ever use that logo file in a link with other text? I can't think of anywhere else it would be used.

BryceStevenWilley commented 10 months ago

Good point; I am confident that's the only place it's used. The code that actually sets the logo in the corner is https://github.com/SuffolkLITLab/docassemble-AssemblyLine/blob/3d0181df9f2c78a87db86e018825cffaf8ce27c4/docassemble/AssemblyLine/data/questions/al_visual.yml#L20-L30, and a quick search in both mplp and Suffolk confirms that it's only ever used in interviews, and in the interview_list.yml (which has separate styles from the rest of Assembly Line).

ekressmiller commented 10 months ago

great thanks!