mplp / docassemble-mlhframework

A docassemble extension.
Other
0 stars 0 forks source link

Easy-to-fix Style suggestions from Feedback #68

Closed BryceStevenWilley closed 10 months ago

BryceStevenWilley commented 10 months ago

Went for the low hanging fixes first. Will get to the more involved ones next.

Suggestion for testing on mobile: in firefox you can press ctrl-shift-m to automatically size your browser to a mobile device (and also acts like it as well, so docassemble thinks that you're a phone). Chrome has a similar thing, but you have to open dev tools and click on "Responsive" above the window to select the phone size.

This PR fixes the following:

ekressmiller commented 10 months ago

This looks great, doing a little testing now.

image

The footer options seem to be right-justified on my iphone 13 mini in Safari and Chrome.

ekressmiller commented 10 months ago

image I think the text at the bottom should say "tap "Sign in or sign up to save answers" to match the menu language.

BryceStevenWilley commented 10 months ago

The footer options seem to be right-aligned on my iphone 13 mini in Safari.

Yes, it's still right aligned. The main change there was to make sure the text wasn't too big so you can see all three options. I think we still want right-aligned for mobile screens.