mplp / docassemble-mlhframework

A docassemble extension.
Other
0 stars 0 forks source link

Translate system phrases to avoid "register" #70

Closed BryceStevenWilley closed 10 months ago

BryceStevenWilley commented 10 months ago

Prefering sign up as well, a bit simpler language.

With these config changes, fix #60:

words:
  - docassemble.mlhframework:data/sources/us-words.yml
  - docassemble.base...
...
register page heading: Sign up
register page title: Sign up
register page tab title: Sign up
register page submit: |
  Your password must be 6 characters long with 1 lowercase, 1 uppercase, and 1 number.
ekressmiller commented 10 months ago

looks good to me! I'll merge and make the config changes in both dev and prod.

ekressmiller commented 10 months ago

image Looking good! This link still says "register" and I'm not sure how to figure out if there's a way to edit that. (I tried just adding that phrase to our us-words.yml but it did not seem to work.) Not a huge deal but just noting it in case there's an easy fix you're aware of @BryceStevenWilley

ekressmiller commented 10 months ago

Just noticed there's two versions of "New here? Register." in the docassemble base words file and one of them has two spaces in the middle instead of just one. I'll try again with two spaces and see if that makes a difference.

ekressmiller commented 10 months ago

it worked! disregard above

BryceStevenWilley commented 10 months ago

Good catch! That's fairly annoying, but unavoidable with how the translation system is designed. I'd leave both the phrases with one space and two spaces in there; I might remove that extra space upstream as there are language translations that don't seem to have the two spaces.