mplp / docassemble-mlhframework

A docassemble extension.
Other
0 stars 0 forks source link

Does interview list show progress completion when progress bar is turned off? #86

Closed BryceStevenWilley closed 7 months ago

BryceStevenWilley commented 10 months ago

It shouldn't if it does currently, but needs testing. AL fix needed

Google doc comment link: ?disco=AAABDEjMkwo

BryceStevenWilley commented 10 months ago

Looked into this: we can turn off the progress bar with:

features:
  progress bar: False

But the interview list screen will still show the progress if we call set_progress or it's on any question. The progress bar is still showing in the Letter to Landlord interview at the moment, but I tested turning off the bar, and the interview list then just shows "Page 6", or whatever page you are on. Going to transfer this issue to that repo.

ekressmiller commented 10 months ago

Thanks for looking into this Bryce. If I'm following you, this means if we want to completely disable the progress bar both in the interview and on the My Interviews page, we need to both:

Is that right?

BryceStevenWilley commented 9 months ago

Yep, that's right!

The technical details are that the interview list page looks for a variable named progress in the interview session information. Calling set_progress directly sets that variable, but also leaving the progress bar enabled will make docassemble automatically increment the progress value too. So both have to be turned off for the progress variable to not be present.

ekressmiller commented 7 months ago

We've decided to turn progress bars on for now and watch for buggy behaviors.