mplushnikov / lombok-intellij-plugin

Lombok Plugin for IntelliJ IDEA
Apache License 2.0
3.11k stars 637 forks source link

Warning should not be displayed if "delegate build to gradle" is enabled #524

Open brempusz opened 5 years ago

brempusz commented 5 years ago

Short description

"Lombok Requires Annotation Processing" warning is displayed even if IDEA option File | Settings | Build, Execution, Deployment | Build Tools | Gradle | Runner | Delegate IDE build/run actions to gradle is enabled.

Expected behavior

Warning should not be displayed.

Version information

Steps to reproduce

  1. import gradle project in IDEA
  2. enable File | Settings | Build, Execution, Deployment | Build Tools | Gradle | Runner | Delegate IDE build/run actions to gradle
  3. disable File | Settings | Build, Execution, Deployment | Compiler | Annotation Processors | Enable annotation processing
    1. close the project
    2. open the project (warning will appear)

NOTE: after few tries I noticed that steps 2 and 3 are optional (after importing gradle project build delegation was enabled by default and annotation processing was disabled)

Sample project

https://github.com/brempusz/net.bartoos.bugs.lombok.idea-plugin-misleading-warning

NOTE: my .idea directory is attached as archive my-dot-idea.tar.gz (so you can reproduce the issue without removing my version of .idea directory)

Additional information

I think the problem is here: it should also check if delegating build to gradle is enabled. https://github.com/mplushnikov/lombok-intellij-plugin/blob/cddc5353822e66ade768c78348e12df6ee98f247/src/main/java/de/plushnikov/intellij/plugin/LombokPluginProjectValidatorComponent.java#L90

brempusz commented 5 years ago

Since v0.25 this warning can be disabled manually on project level. See #522.