Feature/fixes by pionect

dducro commented 7 years ago

Hey,

I changed the following things:

Check if migrations ran in service provider before querying the database. If the package is added by a deploy service, it fails because it tries to fetch webhooks before the migrations are run.
Remove dynamic migration dates. This is because I needed to change the migration in an other package in stead of the underlying Laravel project. It's impossible to override a migration in an other package if "vendor:publish" is run by a deploy service and the migration name is unknown. (the files are copied after all the service providers have been triggered, so the check if the migration already exists doesn't work in this case)
made tenant_id unsigned This is done so I can set a foreign key to another table.
add missing : to eloquent events in README The webhooks weren't triggering because I missed a : in the event name.

Hope I provided enough info and you accept this pull request! :)

mpociot commented 7 years ago

Thanks for the PR!

Do you have any idea on why the tests are failing on 5.6 and 7.0?

dducro commented 7 years ago

Hey,

Thanks for your response! I haven't checked the tests, but I noticed the the current build status on master is failing. So I assumed it had something to do with the tests or a earlier PRs.

Let me know if I can do anything.

ps. I'm on php 7.0 without issues.

dducro commented 7 years ago

The migrations don't work in CommandsTest, so the tests that use the database fail..

codecov-io commented 7 years ago

Current coverage is 64.79% (diff: 90.90%)

Merging #40 into master will decrease coverage by 0.39%

@@             master        #40   diff @@
==========================================
  Files            11         11          
  Lines           270        267     -3   
  Methods          42         42          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            176        173     -3   
  Misses           94         94          
  Partials          0          0

Powered by Codecov. Last update 0e3f90e...a6f9b9d

dducro commented 7 years ago

Tests green :)

mpociot commented 7 years ago

That's awesome! Also thanks for modifying the strings to ::class ❤️

mpociot / captainhook

Feature/fixes by pionect #40

Current coverage is 64.79% (diff: 90.90%)