search

mpociot / captainhook

Add Webhooks to your Laravel app, arrr
335 stars 26 forks source link

Call to undefined method Illuminate\Events\Dispatcher::firing() #42

Open enniel opened 7 years ago

enniel commented 7 years ago 
Call to undefined method Illuminate\Events\Dispatcher::firing()

The method got removed here laravel/framework@dbbfc62

se468 commented 6 years ago

I'm having the same issue (Laravel 5.6). Is there any updates on this?

oh-bala commented 6 years ago

@se468 , @enniel 's patch needs to be adjusted a little bit of checking Laravel version to make it work with Laravel >= 5.4.0, for example, so you can workaround this to start using this package with Laravel 5.6.

if (version_compare('5.4.0', $this->app->version(), '<=')) { $this->registerEventDispatcher(); }

Just remember this can create new issue that I don't know yet. Like with Totem package, most php artisan commands creates Maximum function nesting level of '256' reached, aborting! exception (ensure you have xdebug enable to see this error). Then I have to change the listeners of specific event I really want instead of elouqent.*, which I think shall be a good practice.

mailnike commented 5 years ago

I am getting same error? anyone got this working for Laravel 5.5? :(