search

mpociot / teamwork

User to Team associations with invitation system for the Laravel 5 Framework
MIT License
1.07k stars 170 forks source link

Typehint $app #124

Closed rmccullagh closed 4 years ago

rmccullagh commented 4 years ago

For the Laravel service container to properly construct an instance of Teamwork, we must type the parameters.

okaufmann commented 4 years ago

Hi @rmccullagh

Thanks for your PR!

Let me understand this right: you need this when resolving the class directly when not using the existing Facade?

If this is the case, can't we just update the TeamworkServiceProvider having an alias teamwork resolving to the Teamwork class then?

rmccullagh commented 4 years ago

Hi @okaufmann,

Yes, this PR would allow the Laravel container to resolve an instance of Teamwork. Your solution would also work.

okaufmann commented 4 years ago

Great! I've added the alias and released a new version (6.0.3)