mpociot / teamwork

User to Team associations with invitation system for the Laravel 5 Framework
MIT License
1.07k stars 170 forks source link

Add validation of name and email #89

Closed Jeroen-G closed 4 years ago

Jeroen-G commented 6 years ago

This PR adds a request validation to the controller stubs for the name and email entered by the user when creating a team or an invite.

codecov-io commented 6 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files          15       15           
  Lines         356      356           
=======================================
  Hits          271      271           
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffea927...57b80db. Read the comment docs.

okaufmann commented 4 years ago

Would you like to resolve the conflicts? I caused them by changing some things. Sorry about that :/

Jeroen-G commented 4 years ago

@okaufmann I can't because I have deleted my fork :/

okaufmann commented 4 years ago

Ok, then I'll take your changes right in a commit. Thanks :)

okaufmann commented 4 years ago

It's now included https://github.com/mpociot/teamwork/commit/fee391ad7392d647b84fee54f14a0743671d5e13

Thanks again!