mpogue2
commented
1 month ago OK, the problem was that although the pitch/tempo WERE getting updated in the playlists appropriately, there was nothing that triggered a SAVE AFTER 10 SECONDS (kicked off the Playlist Slot Watcher Timer). So, the new value did not get saved.
With this commit, I decided to do a couple of things:
- fixed the bug, so that if a song is loaded from playlist N, and the tempo/pitch are changed, then after 10 seconds of no further changes the playlist will get written to disk
- I brought back the (subtle) BOLD-ITALICization of the playlist row number and the playlist pitch and tempo columns, when a playlist item is loaded. This tells the user that this item will be edited, when changing pitch/tempo sliders.
- I decided NOT to bring back the "arrow". Instead, I just have the BOLD-ITALIC thing going on.
Commit: 8740f839d4b453a60fb6b3278683e8ced906000a
NOTES: Pitch/tempo affect a playlist item if (and only if) an item from that playlist has been loaded. Also, a subtle clue is given when a playlist item has been loaded: the row number and pitch/tempo columns are bold/italicized. Also, visibility of pitch and tempo columns in the playlists now follow the View > Columns > {Pitch, Tempo} settings in the View menu. Maybe someday the playlist setting and the darkSongTable setting can be separated, but today is not that day. Let's see what people think (or maybe nobody will notice, because they don't turn on Pitch/Tempo in the darkSongTable?)...
To reproduce:
Expected: new pitch/tempo are in effect Got: old pitch/tempo are still used (pitch/tempo not updated in the playlist itself)