Bug: can't edit cuesheet sometimes, gets stuck

[mpogue2]

@sharmanr If a cuesheet is left visible because of peek, when user loads a darkSongTable patter from darkSongTable, clicking the UNLOCK button to edit the peeked-at cuesheet gives no save buttons, and we have to restart the app to get out of this state.

Should the cuesheet be editable from there? Disabling UNLOCK in this use case seems pretty confusing to me, so it would be nice to make it editable. It SEEMS to me like it should be editable from there ideally.

NOTE: This bug existed before I moved the templates to the lyrics/templates folder, in 7718cbdd7af8d3602d02dc3f933e7433af39dc82 .

DISCUSSION: There are some major interactions between templates, editing of templates (which I was trying to get working), and the way that peek is implemented. I tried a couple of different approaches (some of which I had to back out), and I was unable to get editing of templates to work while also retaining PEEK.

Top-of-tree right now (6f9e3d1547118d7f1fd193a752e56bbeb43dc769) has the bug described above.

So, top-of-tree currently:

• has the above bug
• editing a lyrics cuesheet does seem to work (including save, save as, and revert)
• lyrics/templates are correctly shown when patter has no cuesheet matches, BUT you can't edit the template (same bad state problem described above, if you try)

I'm not sure how to do editing of templates using the lyrics editor. What I tried:

• appending the templates to the dropdown menu. This worked REALLY nicely for editing, but it also broke PEEK, because PEEK expects zero items in the dropdown to mean "no matches". I could not figure out how to unwind this. I tried!
• treating a loaded template separately, that is, indicating to the code that although it's loaded, it's NOT REALLY a cuesheet. This broke editing of normal singing call cuesheets, and I could not figure out how to make it work.

I'm also not sure how to add a NEW button to make the templates editable (the alternate approach). The NEW button could make a new cuesheet that could then be Save AS'ed, but we can't really edit it in the cuesheet editor, because that still breaks peek.

I gotta mull on this for a while, to figure out what a good UX would be:

• allows editing of templates, AND
• allow instantiating of templates, AND
• whatever is visible in the cuesheet editor can be edited, saved/save-as'ed/reverted, AND
• doesn't break PEEK (which is super useful)

For now, don't try to edit templates, and don't try to edit a PEEKed-at cuesheet.

Any suggestions?

[pkbott]

Hate to throw more issues at you, but here’s another one:When I copy and paste from one cuesheet to another, let’s say a singing call figure as an example, the text goes to a smaller font on the pasted one.  When that happens, there’s no way to enlarge the font. In fact, the only way to retain the font is to retype the entire cuesheet. This happens even on the two column cuesheet as I experimented a little bit last night.

[mpogue2]

@pkbott I've opened #1128 for this one. If you have more info on how to reproduce (e.g. the from and to files), it would be great if you could post them there. I was unable to reproduce this in my testing. I just did UNLOCK, COPY, REVERT. Then with a second cuesheet I did UNLOCK, PASTE, and it came out with the correct sizes.

[pkbott]

Will try again and hitting save anyways. Never did hit save because it didn’t look right. Ready to try something FUN, UNIQUE and @. Square Dance Group:  https://www.facebook.com/groups/squaredanceforfun/On Jun 11, 2024, at 6:29 PM, Mike Pogue @.> wrote: @pkbott I've opened #1128 for this one. If you have more info on how to reproduce (e.g. the from and to files), it would be great if you could post them there. I was unable to reproduce this in my testing. I just did UNLOCK, COPY, REVERT. Then with a second cuesheet I did UNLOCK, PASTE, and it came out with the correct sizes.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>