Bug: Light Mode -- No Indicator after patter timer set

[pkbott]

This was a surprise this evening. Have always loved this feature (visual warning for long patter) and tonight it never came on at all. Might be another issue.

[pkbott]

This is the faint image of the timer counting - it wasn't dim in earlier versions or maybe it was and I didn't notice it???

[pkbott]

ok so now it is working here at home but wasn't this evening although I did change the time tonight after getting home. I am testing on a different backup computer and did not change the time on that one. Still the overall timer is very dim as pictured above and don't remember that. Worked fine on both computers at home...strange.

[mpogue2]

I think there are two problems here:

• the elapsed timer in Light Mode is dim, which is incorrect.
• the elapsed timer doesn't turn to red when the time limit is reached.

The first problem above is a bug, and I verified that it is present on my machine as well. The second problem above I could not reproduce on my machine. It does turn to red, and then starts flashing a few seconds later. Since you had it on one machine but not the other, it might be an intermittent problem.

[mpogue2]

Dim: OK in V1.0.5, broken in V1.0.6

[mpogue2]

Fixed by: c5468b364e1d6cbf89014b41f40011284d22b1aa

The Light Mode warningLabel no longer uses the Dark mode warningLabel color. And, I tested to make sure that the color of the Light Mode warning label changes to red when the time is up, and 15 seconds later it flashes between the time and the work "LONG" (which was what it was supposed to do).

[pkbott]

Edit: I may take this comment back after playing a little more as the patter timer shows on the CUESHEET tab but NOT the MUSIC tab (in both light/dark modes). After more testing, the timer on the cue sheet tab is not a cumulative timer either, it resets to the loop points each time through and never gets to the warning mode. Just another comment on this one (since I rarely use dark mode), where does the warning for log tip show in dark mode? I would assume above above the waveform near the end but have never seen it to know?

I think it needs to show on the music tab regardless as in my opinion the timer should be on the main page regardless of what is playing as a reminder I think. I also have my patter music in a different folder than what is listed in the preferences folder if this helps.

There is still a bug with this one. Started testing today and the patter timer came up, let it play in the background after I added a desktop and was doing something else. When I came back, the patter timer is gone. I can click where it should be and there is a red 0:00 that shows but never counts again and disappears.

[mpogue2]

DARK MODE

The time-in-tip + warning indicator field in Dark Mode (0:09 here):

and the same thing on the cuesheet tab (0:09 here):

LIGHT MODE

And, the time-in-tip + warning indicator field in Light mode (0:09 here):

and the same thing on the cuesheet tab (0:09 here):

are supposed to all be the same at all times.

If they are not, I believe that's a bug!

[mpogue2]

Yeah, I just saw this here, too.

Cuesheet tab, LIGHT Mode (stuck at red 1:11):

Music tab (missing):

Then when I hit PLAY (still in Light Mode), it restarted at zero, but both fields stayed visible on Music and Cuesheet tabs, and continued to count (which is correct).

Well, it ran for a while, and then got stuck again at 1:22 . Weird!

[pkbott]

Definitely some issues with that bug for sure. Again, my issues were a little bit different because I don’t have the pattern folder defined in the preferences section. It’s just another folder to take advantage of the automatic color change from light to dark mode.

On Thu, Aug 1, 2024 at 4:29 PM Mike Pogue @.***> wrote:

Yeah, I just saw this here, too.

Cuesheet tab, LIGHT Mode (stuck at red 1:11): image.png (view on web) https://github.com/user-attachments/assets/2bf66237-c5b1-401e-8b03-9741f9eb9d3a

Music tab (missing): image.png (view on web) https://github.com/user-attachments/assets/b4d71a67-d64b-49b3-8b00-611e3917096b

Then when I hit PLAY (still in Light Mode), it restarted at zero, but both fields stayed visible on Music and Cuesheet tabs, and continued to count (which is correct).

Well, it ran for a while, and then got stuck again at 1:22 . Weird!

— Reply to this email directly, view it on GitHub https://github.com/mpogue2/SquareDesk/issues/1129#issuecomment-2263926683, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ7Z2QMS7N7IVRR3CY4CGLZPKLD5AVCNFSM6AAAAABJLIUKF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTHEZDMNRYGM . You are receiving this because you authored the thread.Message ID: @.***>

[mpogue2]

And now I can't get it to fail again....huh?

[mpogue2]

OK I think I can get it to do this in both Light and Dark Modes now.

The key is to not let it play music, by pressing STOP and then waiting. About a minute later it will disappear the Music Tab field, but the Cuesheet field is RED and stuck.

I'll have to double check the code, but I think it's "as-designed" to declare the tip over, if the music is paused or stopped for a long period of time (like > 1 min).

But, there is still a bug here, in that the fields on the Music and Cuesheet Tabs should have behaved identically, and they did not. So, I'll open a new Issue on that.

[mpogue2]

Just to follow up on the "the timer on the cue sheet tab is not a cumulative timer either" thing that you mentioned.

In this example:

the "01:24" here is the cumulative timer ("time-in-tip"), and the "2:54" here is the "time-in-song" timer.

But in your picture, I see the red "intro", meaning that it thinks it's a singing call, and so that field shows what section you are in the singing call.

But, like you said "my issues were a little bit different because I don’t have the pattern folder defined in the preferences section".

I now think you're absolutely right on that! It's not in a known patter folder, as far as the "cumulative Timer/section" is concerned, so you got the section info, even though you wanted the cumulative timer (Time-in-tip).

I'm not quite sure how to solve this! Maybe...

• if it's in an "UNKNOWN" folder type, those fields should always act like Time-In-Tip.

Do you think that will work in all cases for you?

[pkbott]

I do think that works

[mpogue2]

OK, I think I can make this work. It's a little tricky, though, because a non-patter-non-singer will trigger a break, so that functionality might be messed up, if you are using a non-patter-non-singer folder name to work around the light/dark color issue.

This commit makes "Undefined" song types act ALMOST like patters. The only difference will be that Loop will NOT default to ON for Undefined song types. If, however, you turn on looping for an Undefined type, then it will be remembered. With undefined song types you will not get singing call coloring in the song position bar, and you will get a generic color for clock coloring (not the Patter color). Flash calls will be enabled for all Undefined type songs (if Flash Calls are enabled at all).

This commit also fixes #1158, so the warningLabel/timerLabels should be the same on Music and Cuesheet tabs now.

Commit: 0e5fc9c363fe6759e46968ce86db52749a727232

[pkbott]

That would be awesome.

Would that be a new option to turn looping on for undefined then or am I missing something?

On Mon, Aug 5, 2024 at 7:43 PM Mike Pogue @.***> wrote:

OK, I think I can make this work. It's a little tricky, though, because a non-patter-non-singer will trigger a break, so that functionality might be messed up, if you are using a non-patter-non-singer folder name to work around the light/dark color issue.

This commit makes "Undefined" song types act ALMOST like patters. The only difference will be that Loop will NOT default to ON for Undefined song types. If, however, you turn on looping for an Undefined type, then it will be remembered. With undefined song types you will not get singing call coloring in the song position bar, and you will get a generic color for clock coloring (not the Patter color). Flash calls will be enabled for all Undefined type songs (if Flash Calls are enabled at all).

This commit also fixes #1158 https://github.com/mpogue2/SquareDesk/issues/1158, so the warningLabel/timerLabels should be the same on Music and Cuesheet tabs now.

Commit: 0e5fc9c https://github.com/mpogue2/SquareDesk/commit/0e5fc9c363fe6759e46968ce86db52749a727232

— Reply to this email directly, view it on GitHub https://github.com/mpogue2/SquareDesk/issues/1129#issuecomment-2270102927, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ7Z2USDBNXYRG7W7CRKGTZQAEZRAVCNFSM6AAAAABJLIUKF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGEYDEOJSG4 . You are receiving this because you authored the thread.Message ID: @.***>

[mpogue2]

No new option -- just hit the "L" key, which toggles looping for the currently-loaded song. If you can see the brackets (blue in Light node), "[" and "]", then looping is on. This will be remembered for this song next time you load it.

So, when a song is loaded for the very first time,

• if Patter or Extra, looping is ON by default, but it can be manually toggled
• if Singer, Vocal, or Undefined, looping is OFF by default, but it can be manually toggled

[pkbott]

Got it. I like this as a fix.

On Mon, Aug 5, 2024 at 7:59 PM Mike Pogue @.***> wrote:

No new option -- just hit the "L" key, which toggles looping for the currently-loaded song. If you can see the brackets (blue in Light node), "[" and "]", then looping is on. This will be remembered for this song next time you load it.

So, when a song is loaded for the very first time,

• if Patter or Extra, looping is ON by default, but it can be manually toggled
• if Singer, Vocal, or Undefined, looping is OFF by default, but it can be manually toggled

— Reply to this email directly, view it on GitHub https://github.com/mpogue2/SquareDesk/issues/1129#issuecomment-2270119028, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ7Z2Q6NRHWF5T72XEEHF3ZQAGXTAVCNFSM6AAAAABJLIUKF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGEYTSMBSHA . You are receiving this because you authored the thread.Message ID: @.***>