search

mpogue2 / SquareDesk

Fully-featured music player and sequence designer, designed for square dance callers
9 stars 4 forks source link

Bug: singing call doesn't auto-switch to cuesheet on first playback, if it's a non-standard folder name #1137

Open mpogue2 opened 2 months ago

mpogue2 commented 2 months ago

There are a bunch of places in the code that look for "singing" in the filename, even though singing calls might be in a folder called "singers", where "singers" was in the Preferences > Music tab as an allowed type for singing calls.

So, if the folder name isn't "singing", it isn't recognized as a singing call, and the auto-switch-to-Cuesheet-tab feature doesn't work.

This problem found by David D.

mpogue2 commented 2 months ago

It turns out that this problem existed in a number of places, including playlists and the "peek" feature. This commit fixes all of those places (I think!).

Fixed by: 5550be105d55ab85f023b9f4047b04c507c61bd0

mpogue2 commented 2 months ago

The reason why I didn't detect this problem is that I don't use non-standard names for the folders. But, Dave D does, and so he encountered this problem. Thanks, Dave D!