mpogue2 / SquareDesk

Fully-featured music player and sequence designer, designed for square dance callers
10 stars 4 forks source link

Bug: Long Tip Warning doesn't show up in Light Mode #1153

Open mpogue2 opened 1 month ago

mpogue2 commented 1 month ago

From Paul:

"Here’s another bug. I’m running into again. Took pictures this time. Been playing the same song for 17 minutes so far I have a tip timer warning at 15 minutes with no warning after that time limit also no tip time count either next to VU meter including pictures.

Thinking it has to be something strange because I’m running 1.0.9 version on one machine and on another identical machine with the exact same problem 1.0.5 version. I do copy the Square desk folder from one machine to the other, so the problem is being transferred from one to the other."

Pictures he provided (note that the second hand is moving here, and the Time-in-tip is different by 1 second in each):

image

image

image

mpogue2 commented 1 month ago

Could you take a pic of the Experimental tab in the Preferences dialog for me? Specifically I'd like to see what the Patter timer and Clock Coloring settings are.

pkbott commented 1 month ago

Here is an image of the preferences tab as requested.

Screenshot 2024-07-30 at 7 20 10 AM
mpogue2 commented 1 month ago

Thanks! I think this is enough info for me to try to debug this...

pkbott commented 1 month ago

This is my fault. I totally forgot. I took and changed the name of the patter folder on purpose to get the colors to flip between dark and light mode automatically for the text that’s why there’s no more test loop button

On Tue, Jul 30, 2024 at 5:07 PM Mike Pogue @.***> wrote:

Thanks! I think this is enough info for me to try to debug this...

— Reply to this email directly, view it on GitHub https://github.com/mpogue2/SquareDesk/issues/1153#issuecomment-2259210341, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ7Z2TQFQRK3ROAK7BZ4DDZO757TAVCNFSM6AAAAABLVVLHXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGIYTAMZUGE . You are receiving this because you commented.Message ID: @.***>

mpogue2 commented 1 month ago

@pkbott I copied your comment over to the other Issue, where we were talking about the Test Loop button....

I think this Long Tip Warning bug still exists, and still needs to be debugged. So, this Issue remains open.

pkbott commented 1 month ago

I am guessing that this is now not working because I have changed the folder name for patter so that I could benefit from the text color change in switching from dark to light mode as well. SO, it would not be a bug here either but another ENHANCEMENT. I am including a couple screenshots of my folder structure. HOWEVER, I think that a long tip warning should come up AS WELL as a tip timer ALL OF THE TIME. Whatever Music is being played should have a timer running and the ability to have a long tip warning. If I was using a singing call for an extended period of time as a hash I would like to know it.

Screenshot 2024-07-30 at 6 20 13 PM Screenshot 2024-07-30 at 6 21 09 PM
mpogue2 commented 1 month ago

Thanks, this helps!

I don't think that the Long Tip Warning is song-type-specific (at least, it's not supposed to be!). So, the name of the folder (which determines song type) should have affected the Test Loop Button (which right now it Patter-only), but it should not have affected the Long Tip Warning.

My current thinking is to:

pkbott commented 1 month ago

I concur with both

On Tue, Jul 30, 2024 at 6:52 PM Mike Pogue @.***> wrote:

Thanks, this helps!

I don't think that the Long Tip Warning is song-type-specific (at least, it's not supposed to be!). So, the name of the folder (which determines song type) should have affected the Test Loop Button (which right now it Patter-only), but it should not have affected the Long Tip Warning.

My current thinking is to:

  • just leave the Test Loop button always on
  • fix the bug around Long Tip Warning (which I think is probably unrelated, but we never know! :-)

— Reply to this email directly, view it on GitHub https://github.com/mpogue2/SquareDesk/issues/1153#issuecomment-2259333156, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ7Z2VFRZHR7Q56JNXS7JDZPAKLNAVCNFSM6AAAAABLVVLHXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGMZTGMJVGY . You are receiving this because you were mentioned.Message ID: @.***>