music player / dark mode: rename "Loop" button to "Test Loop"

[Gero5]

For better user experience rename the "Loop" button to "Test Loop". That is what is does and the name is the same for the same functionality as on the "Cuesheet" card.

See also #1211 #1209

[mpogue2]

I kinda want to go the other direction on getting the labels to match, that is, I'd really like to rename the "Start Loop" and "End Loop" buttons on the cuesheet page to "[" and "]" for consistency. I was planning to do this when the Cuesheet tab got converted to Dark Mode (which might also update the slider to a waveform display).

I did go back and forth on the "Test Loop" button text, though. I wanted to keep it pretty short, because I'd like to add more (related) controls to the right of it. But, I think you're probably right to emphasize the "Test" rather than the "Loop" part of the function. We could also change it to "Test Loop" now, and rename it to just "Test" later, if/when more space is needed, or it could also auto-change the text based on how much space was available (if needed in the future).

Note: that "Loop" button is also missing a tool tip. AND, the tooltips for "[" and "]" are missing ":"s in the help text that might make the text more readable.

Overall, I think you're right that a rename would be a good idea.

[Gero5]

As a workaround using text I prefer 'Test' or 'Test Loop' over 'Loop'.

I kinda want to go the other direction on getting the labels to match

Yes, that would be good. Why not follow the idea from #1211 and use icons here as far as possible and understandable for the user.

I think the arrows from Mixxx

are good and clear symbols for start and end loop points.

Maybe use the end loop symbol and add an arrow from left to right to symbolize "Test loop"? Somewhat like this: