search

mpogue2 / SquareDesk

Fully-featured music player and sequence designer, designed for square dance callers
10 stars 4 forks source link

Bug: Remove ReplayGain #609

Closed mpogue2 closed 2 years ago

mpogue2 commented 2 years ago

It doesn't work well, and it's just a distraction. Remove it completely. This will also eliminate the need for the mpg123 library.

mpogue2 commented 2 years ago

mp3gain is no longer built, as of 13115c3dcc01414755da33dbb6bb565b537a8dd9 . Note that the .pro files still include it. That will be a separate change.

mpogue2 commented 2 years ago

See also #486 (ReplayGain doesn't work well).

mpogue2 commented 2 years ago

Maybe we should bring back the compressor in its place? kfr does not have a built-in compressor. But, here is a compressor design doc: http://c4dm.eecs.qmul.ac.uk/audioengineering/compressors/documents/Reiss-Tutorialondynamicrangecompression.pdf

This guy has some tasty code: https://github.com/p-hlp/SMPLComp https://github.com/p-hlp/CTAGDRC

And this: https://github.com/DanielRudrich/SimpleCompressor

mpogue2 commented 2 years ago

Replay Gain removed by 689c21a09323fff0f1b4469022e433a914d26970 .