Bug: BoldItalic doesn't simplify correct in cuesheet editor

mpogue2 / SquareDesk

Fully-featured music player and sequence designer, designed for square dance callers

10 stars 4 forks source link

Bug: BoldItalic doesn't simplify correct in cuesheet editor #679

Open mpogue2 opened 2 years ago

mpogue2 commented 2 years ago

BoldItalic doesn't simplify correctly to . In fact, I'm not sure that overlapping types will work properly (fortunately, I don't really ever use these, except for BOLD, which seems to work fine).

mpogue2 commented 1 year ago

BOLD seems to work OK standalone. ITALICS seems to work OK standalone.

But, overlapping doesn't seem to work (e.g. LADIES), because this in the middle can't be simplified to either or .

mpogue2 commented 1 year ago

OK, I made it work, kinda.

I now detect that long combo SPAN, and replace it with B then I then text then /I then /B. This works fine when viewing the file in Safari, but it seems there is a bug in the HTML editor in Qt, which does not render this properly. So, now the simplification is done correctly, but the editor doesn't always show it correctly.

Bug:

B then I then text then /I then /B renders properly in the editor and in Safari.
I then B then text then /B then /I renders as I then text then /I (doesn't make the middle letters bold), but in Safari it is correct.

mpogue2 commented 1 year ago

This code is fragile, and I am sure there are other ways to break it, involving overlapping text classes.

But, it works better now than before, as of a6d661b7885964afa7121c3c888ef14cfbb8a2a4 .