Double check that these are fixed

[mpogue2]

Bugs reported against 0.9.5 by Gero, that should be checked:

• letters of active tab disappear (white-on-white)

• patter loop: tiny break in the music (test this) Features that I think are already implemented:
• looper: Add an overall time counter/stopwatch showing the time elapsed since the music was started. For example after three loops the counter is at 7:23.

[mpogue2]

Testing "tiny break in the music":

With the current top-of-tree version (f8297b599b3eb34fc0a296c841ec9ce9993232d8), I jumped back from a 200Hz section (precisely aligned to the sample) to a 100Hz section (precisely aligned to the sample), and the splice at loop time was sample-accurate. The song was WAV encoded to avoid MP3 artifacts. Here's a picture:

Here is the same test, done with the WAV file converted to MP3. The join is seamless and sample accurate as well:

[mpogue2]

Testing "letters of active tab disappear":

Here's what I see with current top-of-tree:

This was a long-standing Qt bug, and since we've upgraded to later versions of Qt since the 0.9.5 release, this bug has been fixed.

[mpogue2]

Regarding "overall time counter/stopwatch...":

That feature was implemented a while ago, although it might not be documented well. Once the music is started, the big timer numbers (see picture below) reflect "Time in tip", and they continue to count, even though the music may be paused. If the music is stopped entirely (by pressing the STOP button, or pressing the PERIOD key), the Time-In-Tip will go back to zero automatically.

[Gero5]

Regarding "overall time counter/stopwatch...":

For that "patter timer" has to be active in the preferences. From the way it is described there "patter timer after x minutes of patter, visual indicator" I was expecting just a visual indicator only not a time counter. Now I know. :-) It is quite useful for most callers, I guess. Maybe you want to activate it by default?

[mpogue2]

I think it would indeed be good to make "Patter Timer ON" the default. The pull down menu is supposed to refer to what happens after the patter timer expires: either a) an audible indicator (which I use), or b) a visual indicator only (no audible sound is played).

[Gero5]

I tested this with v1.0.4

• letters of active tab disappear (white-on-white) fixed.

• patter loop: tiny break in the music (test this) fixed/much better

• looper: Add an overall time counter/stopwatch works.