mpogue2 / SquareDesk

Fully-featured music player and sequence designer, designed for square dance callers
10 stars 4 forks source link

Bug?: Search for matching lyrics #818

Open Gero5 opened 1 year ago

Gero5 commented 1 year ago

the search for matching lyrics without a label is working very well most of times. I do not understand why it is different here: I have a song with the file name 'Gentle On My Mind.mp3'. In the lyrics folder there are five files exactly matching that name Bildschirm­foto 2023-04-04 um 17 56 32 but on the lyrics tab none of those is displayed: Bildschirm­foto 2023-04-04 um 17 57 29 Probably the list is being cut off after the first ten matches and there are too many "...on my mind" songs. feature request: Display exact matches in name first when there is no label to the song.

mpogue2 commented 1 year ago

@Gero5 We do not have a limit to the number of cuesheets that can match. On my system, I have 29 matches to "Gentle On My Mind.mp3" in the lyrics pulldown menu. So, matching when there is no label to the song appears to work for me.

But, only 10 are shown in the pulldown menu at a given time. Maybe you didn't see the scrollbar in the pulldown menu?
See screenshot below:

Screenshot 2023-04-14 at 11 49 36 PM

Gero5 commented 1 year ago

re: Maybe you didn't see the scrollbar in the pulldown menu? yes that is probably so. The problem is that it has 30 results and the most relevant are at the end of the list. This is, however, a very Gero specific problem that is not relevant for the average user AFAIS. So you can close this issue without remorse.

danlyke commented 1 year ago

We should figure out what the match quality difference is, though. Is it finding a better match because of things in the label or number? Because I thought I was scoring based on the number of words that hit.

Gero5 commented 1 year ago

@Dan: The better the match the higher in the list would solve the problem. In my case it is not like that. I get a result list with the best matches at the end of the list.

Use Case:

  1. Create a music file named 'Gentle On My Mind.mp3'.
  2. put it in the singing folder.
  3. Expand all 10'000++ lyric files from the lyric library and put them in the lyrics folder.
  4. Start SquareDesk, select 'Gentle On My Mind'.
  5. Look at the lyrics tab.

result: a list of more or less matching names. mainly ' {anything} on my mind ' at the top. best matches on the end. It is not 'scoring based on the number of words that hit' the way I would expect the resulting list to be. if you did implement that maybe it is ascending instead of descending order?

here are the screenshots of my results. at the top: Bildschirmfoto 2023-04-15 um 10 49 19

best results to my human eyes are at the end of the list: Bildschirmfoto 2023-04-15 um 10 52 59

danlyke commented 1 year ago

Thanks. Wonder if a sort order got reversed. Leave this one open, please, and I'll carve out some time to take a look.Message ID: @.***>

Gero5 commented 1 year ago

BTW: Mikes screenshots look like a different kind of order...?

mpogue2 commented 1 year ago

@Gero5 I have multiple different sets of cuesheets on my system!

Gero5 commented 1 year ago

@mpogue2 re: I have multiple different sets of cuesheets on my system! Congrats! My point was that I do not understand why in your screenshot it looks like better matching files are listed on top and my case are listed at the end of the list. Or is it a rule that people with multiple different sets of cue sheets are treated better by SquareDesk? ;-)